Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): mud pull #3171

Merged
merged 18 commits into from
Oct 7, 2024
Merged

feat(cli): mud pull #3171

merged 18 commits into from
Oct 7, 2024

Conversation

holic
Copy link
Member

@holic holic commented Sep 11, 2024

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 706a16c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@latticexyz/cli Patch
@latticexyz/world-modules Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/dev-tools Patch
@latticexyz/explorer Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store-indexer Patch
@latticexyz/store-sync Patch
@latticexyz/store Patch
@latticexyz/utils Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@holic holic mentioned this pull request Sep 11, 2024
Closed
@holic holic marked this pull request as ready for review September 17, 2024 09:40
@holic holic requested a review from alvrs as a code owner September 17, 2024 09:40
alvrs
alvrs previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@alvrs alvrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! note: just tried it out on a base chain and ran into a eth_getLogs is limited to a 10,000 range error

@alvrs
Copy link
Member

alvrs commented Sep 30, 2024

just tried it out on a base chain and ran into a eth_getLogs is limited to a 10,000 range error

should this be fixed by #3217?

@holic
Copy link
Member Author

holic commented Oct 1, 2024 •
edited
Loading

should this be fixed by #3217?

It's fixed for fetching the world deploy, but still needs work for e.g. getting resource IDs.

If we change these to fetchLogs, we're gonna be loading a lot more than we need to every time we need to enumerate through records. This is mostly due to the lack of proper topics support in viem's getLogs calls, so we'd need to implement our own thing on top of viem to get logs by e.g. tableId.

@holic
Copy link
Member Author

holic commented Oct 1, 2024

Okay you nerd sniped me: #3245

@holic holic mentioned this pull request Oct 1, 2024
Merged
@alvrs alvrs merged commit 9e53a51 into main Oct 7, 2024
13 checks passed
@alvrs alvrs deleted the holic/mud-pull branch October 7, 2024 11:10
@holic holic mentioned this pull request Oct 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvrs alvrs alvrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@holic @alvrs